hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6055) Snapshots in HBase 0.96
Date Sun, 15 Jul 2012 16:16:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414689#comment-13414689

Zhihong Ted Yu commented on HBASE-6055:

Flipping through 5 pages on review board is slow. So I am putting down some notes here.

For HStore.java:
The license header doesn't look like the standard format.
Please add audience and stability annotations to this new interface.
+  FileStatus[] getStoreFiles() throws IOException;
+  List<StoreFile> getStorefiles();
Why do we need two methods which are spelled almost the same, yet returning different types
? When refactoring, we should make the code cleaner.
There're many methods which don't have javadoc. Please add javadoc for them.
+  public HStore getDelgate() {
Correct spelling for the above method.
> Snapshots in HBase 0.96
> -----------------------
>                 Key: HBASE-6055
>                 URL: https://issues.apache.org/jira/browse/HBASE-6055
>             Project: HBase
>          Issue Type: New Feature
>          Components: client, master, regionserver, zookeeper
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.96.0
>         Attachments: Snapshots in HBase.docx
> Continuation of HBASE-50 for the current trunk. Since the implementation has drastically
changed, opening as a new ticket.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message