hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Chanan (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-6333) MemStoreScanner {kvsetAtCreation,snapshotAtCreation} should be private and not volatile
Date Thu, 05 Jul 2012 23:56:34 GMT
Gregory Chanan created HBASE-6333:

             Summary: MemStoreScanner {kvsetAtCreation,snapshotAtCreation} should be private
and not volatile
                 Key: HBASE-6333
                 URL: https://issues.apache.org/jira/browse/HBASE-6333
             Project: HBase
          Issue Type: Improvement
    Affects Versions: 0.96.0
            Reporter: Gregory Chanan
            Assignee: Gregory Chanan
            Priority: Minor

I was looking over this code and was confused why these variables were volatile, as they don't
need to be [the constructor, which is the only place the variables are set, is already protected
by a lock].

I doubt this makes much performance difference (I haven't measured); this is more of a documentation
difference to say nothing special is going on here :).

also talks about this, but it doesn't seem to have been implemented.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message