hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6328) FSHDFSUtils#recoverFileLease tries to rethrow InterruptedException but actually shallows it
Date Thu, 05 Jul 2012 00:18:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406791#comment-13406791
] 

Hadoop QA commented on HBASE-6328:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12535129/6328.v1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's
current 4 warnings).

    -1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.catalog.TestMetaReaderEditor

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2323//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2323//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2323//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2323//console

This message is automatically generated.
                
> FSHDFSUtils#recoverFileLease tries to rethrow InterruptedException but actually shallows
it
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6328
>                 URL: https://issues.apache.org/jira/browse/HBASE-6328
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: 6328.v1.patch
>
>
> Coding error is:
> {noformat}
>       try {
>         Thread.sleep(1000);
>       } catch (InterruptedException ex) {
>         new InterruptedIOException().initCause(ex);
>       }
> {noformat}
> The exception is created but not thrown...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message