hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6418) Minor bug in delete flow.
Date Wed, 18 Jul 2012 09:36:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416959#comment-13416959
] 

Anoop Sam John commented on HBASE-6418:
---------------------------------------

@Laxman
Seems fine. I am inline with Lars after more code study and testing.
Delete type will be used only when deleteColumn(byte [] family, byte [] qualifier, long timestamp)
is used.[deleteColumn(byte [] family, byte [] qualifier) also]
This is just one version deletion
There only need to get the cell value and find the TS.
Else in all other types of deletes, need to set either the TS specified by user of the cur
time at RS
                
> Minor bug in delete flow.
> -------------------------
>
>                 Key: HBASE-6418
>                 URL: https://issues.apache.org/jira/browse/HBASE-6418
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0, 0.96.0, 0.94.1, 0.94.2
>            Reporter: Laxman
>            Assignee: Laxman
>
> Timestamp updation in Delete flow is not considering all flavors (Delete record, Delete
Family, Delete Column) of Delete API. Currently its considering Delete Record only. 
>  
> org.apache.hadoop.hbase.regionserver.HRegion.prepareDeleteTimestamps(Delete, byte[])
> {code}
>       for (KeyValue kv: kvs) {
>         //  Check if time is LATEST, change to time of most recent addition if so
>         //  This is expensive.
>         if (kv.isLatestTimestamp() && kv.isDeleteType()) {
> {code}
> Basically used a wrong API.
> kv.isDeleteType() should be KeyValue.isDelete(type);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message