hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6476) Replace all occurrances of System.currentTimeMillis() with EnvironmentEdge equivalent
Date Tue, 31 Jul 2012 18:51:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426014#comment-13426014
] 

Hadoop QA commented on HBASE-6476:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12538589/6476.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 240 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's
current 4 warnings).

    -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.coprocessor.TestCoprocessorInterface
                  org.apache.hadoop.hbase.master.TestClockSkewDetection
                  org.apache.hadoop.hbase.TestKeyValue
                  org.apache.hadoop.hbase.regionserver.wal.TestWALActionsListener
                  org.apache.hadoop.hbase.regionserver.TestQueryMatcher
                  org.apache.hadoop.hbase.metrics.TestMetricsMBeanBase
                  org.apache.hadoop.hbase.filter.TestDependentColumnFilter
                  org.apache.hadoop.hbase.regionserver.TestResettingCounters
                  org.apache.hadoop.hbase.coprocessor.TestRegionObserverStacking
                  org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster
                  org.apache.hadoop.hbase.regionserver.wal.TestHLogMethods
                  org.apache.hadoop.hbase.regionserver.TestBlocksScanned
                  org.apache.hadoop.hbase.util.TestHFileArchiveUtil
                  org.apache.hadoop.hbase.regionserver.TestMinVersions
                  org.apache.hadoop.hbase.regionserver.TestCompactSelection
                  org.apache.hadoop.hbase.regionserver.TestSplitTransaction
                  org.apache.hadoop.hbase.ipc.TestPBOnWritableRpc
                  org.apache.hadoop.hbase.TestSerialization
                  org.apache.hadoop.hbase.regionserver.TestScanner
                  org.apache.hadoop.hbase.util.TestHBaseFsckComparator
                  org.apache.hadoop.hbase.util.TestByteBloomFilter
                  org.apache.hadoop.hbase.master.cleaner.TestHFileCleaner
                  org.apache.hadoop.hbase.regionserver.TestKeepDeletes
                  org.apache.hadoop.hbase.util.TestThreads
                  org.apache.hadoop.hbase.regionserver.TestRSStatusServlet
                  org.apache.hadoop.hbase.master.TestCatalogJanitor
                  org.apache.hadoop.hbase.regionserver.TestRegionSplitPolicy
                  org.apache.hadoop.hbase.regionserver.TestScanWithBloomError
                  org.apache.hadoop.hbase.client.TestIntraRowPagination
                  org.apache.hadoop.hbase.regionserver.TestHRegionInfo
                  org.apache.hadoop.hbase.regionserver.TestWideScanner
                  org.apache.hadoop.hbase.migration.TestMigrationFrom090To092
                  org.apache.hadoop.hbase.monitoring.TestTaskMonitor
                  org.apache.hadoop.hbase.regionserver.TestColumnSeeking
                  org.apache.hadoop.hbase.TestCompare
                  org.apache.hadoop.hbase.filter.TestFilter
                  org.apache.hadoop.hbase.regionserver.TestStoreFile
                  org.apache.hadoop.hbase.filter.TestColumnPrefixFilter
                  org.apache.hadoop.hbase.monitoring.TestMemoryBoundedLogMessageBuffer
                  org.apache.hadoop.hbase.filter.TestMultipleColumnPrefixFilter

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2462//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2462//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2462//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2462//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2462//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2462//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2462//console

This message is automatically generated.
                
> Replace all occurrances of System.currentTimeMillis() with EnvironmentEdge equivalent
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-6476
>                 URL: https://issues.apache.org/jira/browse/HBASE-6476
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 6476.txt
>
>
> There are still some areas where System.currentTimeMillis() is used in HBase. In order
to make all parts of the code base testable and (potentially) to be able to configure HBase's
notion of time, this should be generally be replaced with EnvironmentEdgeManager.currentTimeMillis().
> How hard would it be to add a maven task that checks for that, so we do not introduce
System.currentTimeMillis back in the future?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message