hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6431) Some FilterList Constructors break addFilter
Date Thu, 26 Jul 2012 02:34:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422849#comment-13422849
] 

Zhihong Ted Yu commented on HBASE-6431:
---------------------------------------

The second question above was about this:
{code}
public FilterList(final List<Filter> rowFilters) {
{code}
Not this:
{code}
public FilterList(final Filter... rowFilters) {
{code}

The third question pertains to the fact that Arrays.asList() creates ArrayList internally.
I don't see the need to wrap it with new ArrayList<Filter>.
                
> Some FilterList Constructors break addFilter
> --------------------------------------------
>
>                 Key: HBASE-6431
>                 URL: https://issues.apache.org/jira/browse/HBASE-6431
>             Project: HBase
>          Issue Type: Bug
>          Components: filters
>    Affects Versions: 0.92.1, 0.94.0
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>            Priority: Minor
>         Attachments: 0001-HBASE-6431.-Some-FilterList-Constructors-break-addFi.patch
>
>
> Some of the constructors for FilterList set the internal list of filters to list types
which don't support the add operation. As a result 
> FilterList(final List<Filter> rowFilters)
> FilterList(final Filter... rowFilters)
> FilterList(final Operator operator, final List<Filter> rowFilters)
> FilterList(final Operator operator, final Filter... rowFilters)
> may init private List<Filter> filters = new ArrayList<Filter>(); incorrectly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message