hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4050) Update HBase metrics framework to metrics2 framework
Date Wed, 11 Jul 2012 17:51:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411762#comment-13411762
] 

Elliott Clark commented on HBASE-4050:
--------------------------------------

The reflection option seems like it would be a big perf hit.  Reflection basically means that
nothing ever gets inlined so all function calls into metrics2 code would be very expensive.
 Since it seems like we are adding more and more instrumentation this perf impact would only
grow.  In addition as more hadoop versions come out all of our reflection code would get much
more complicated and brittle.

The conditionally loaded jar would be nice in that the JIT would only see one version of the
factory classes on the classpath and everything could be optimized just like any other jvm
run jit'd code. In addition there are other places that we use reflection to do things conditionally
and a conditionally loaded jar would be nice.

So I'm for #2.
                
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
>                 Key: HBASE-4050
>                 URL: https://issues.apache.org/jira/browse/HBASE-4050
>             Project: HBase
>          Issue Type: New Feature
>          Components: metrics
>    Affects Versions: 0.90.4
>         Environment: Java 6
>            Reporter: Eric Yang
>            Assignee: Alex Baranau
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+, and it might
get removed in future Hadoop release.  Hence, HBase needs to revise the dependency of MetricsContext
to use Metrics2 framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message