hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6433) Improve HBaseServer#getRemoteAddress by utilizing HBaseServer.Connection.hostAddress
Date Fri, 20 Jul 2012 20:33:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419535#comment-13419535
] 

stack commented on HBASE-6433:
------------------------------

@binlijin Why not change what getRemoteIp does internally (your patch copies much of the body
of getRemoteIp).  Is it that getRemoteIp is used in places where Call has not had host address
set yet?
                
> Improve HBaseServer#getRemoteAddress by utilizing HBaseServer.Connection.hostAddress
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-6433
>                 URL: https://issues.apache.org/jira/browse/HBASE-6433
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>            Assignee: binlijin
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 6433-getRemoteAddress-trunk.txt, HBASE-6433-90.patch, HBASE-6433-92.patch,
HBASE-6433-94.patch, HBASE-6433-trunk.patch
>
>
> Currently, HBaseServer#getRemoteAddress would call getRemoteIp(), leading to call.connection.socket.getInetAddress().
> The host address is actually stored in HBaseServer.Connection.hostAddress field. We don't
need to go through Socket to get this information.
> Without this patch it costs 4000ns, with this patch it costs 1600ns

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message