hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj Das (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5705) Introduce Protocol Buffer RPC engine
Date Tue, 10 Jul 2012 00:38:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409983#comment-13409983
] 

Devaraj Das commented on HBASE-5705:
------------------------------------

I updated RB with the new patch. Yes, the PB stuff goes via writables still. Some of the stuff
can be put within a if/else logic for PB vs. Writable but when I did it, it seemed to make
the code complex. So am thinking of doing the work of making RPC use as much of PB as possible
as a follow up (and at that time, remove the WritableRpcEngine/Invocation classes), when all
the application protocols are converted to PB. Open to feedback on this aspect. 
Once the above is done, the use of PB RPC Engine should make things more efficient in terms
of avoiding copies in the rpc layer (for example in the RPC layer, if we needed to write a
pair of {message-length, message}, in the current RPC, we would need to serialize the Writable
object into a buffer, and then get the length of the buffer. In the PB world, every message
has a getSerializedSize method generated..)
                
> Introduce Protocol Buffer RPC engine
> ------------------------------------
>
>                 Key: HBASE-5705
>                 URL: https://issues.apache.org/jira/browse/HBASE-5705
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 5705-1.patch, 5705-2.1.patch
>
>
> Introduce Protocol Buffer RPC engine in the RPC core. Protocols that are PB aware can
be made to go through this RPC engine. The approach, in my current thinking, would be similar
to HADOOP-7773.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message