hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6411) Move Master Metrics to metrics 2
Date Tue, 24 Jul 2012 03:31:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421145#comment-13421145
] 

Zhihong Ted Yu commented on HBASE-6411:
---------------------------------------

For TestMasterMetrics:
{code}
+  private void startCluster() throws Exception{
{code}
Normally such method is annotated with @Before
{code}
+    mxBean = CompatibilitySingletonFactory.getInstance(MBeanSource.class).register("hbase",
"HMaster,sub=MXBean", mxBeanInfo);
{code}
The above line is longer than 100 characters.

If TestMasterMetrics is placed in master.metrics package, the following method can be package-private:
{code}
+  // for unit-test usage
+  public MasterMetricsSource getMetricsSource() {
{code}
{code}
+public class MetricsAssertsImpl extends MetricsAsserts {
{code}
Please add javadoc for the above class.

                
> Move Master Metrics to metrics 2
> --------------------------------
>
>                 Key: HBASE-6411
>                 URL: https://issues.apache.org/jira/browse/HBASE-6411
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-6411-0.patch, HBASE-6411-1.patch, HBASE-6411_concept.patch
>
>
> Move Master Metrics to metrics 2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message