hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4050) Update HBase metrics framework to metrics2 framework
Date Wed, 18 Jul 2012 23:18:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417808#comment-13417808
] 

Elliott Clark commented on HBASE-4050:
--------------------------------------

# I would like that, except I think that grouping things together all under an hbase node
in jmx is nice.  Since hadoop too the top one.  That leaves us with sharing the metrics system
name. So all of the contexts will have to be well named so that it's pretty evident which
daemon they came from.
# Sure.  That would make it easier to remove if we ever get all the methods that we need on
the hadoop metrics registry.
# But MetricMutableGaugeLong and MetricMutableCounterLong will never implement our interfaces
so you would be forced to create whole wrapper classes around every class.  I think it would
be better if sources just implemented specialized methods for interacting with known MetricMutable's.
 Then you get all the speed and it abstracts the actual metrics from any code in hbase-server
# I was going to handle this by having ServiceLoader find a factory implementation that creates
an implementation of the source needed.
# As far as moving SourceImpl into hbase-hadoop-compat.  It's not really possible because
it needs to implement interfaces that come from hadoop.  And those interfaces refer to classes
that have changed.
                
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
>                 Key: HBASE-4050
>                 URL: https://issues.apache.org/jira/browse/HBASE-4050
>             Project: HBase
>          Issue Type: New Feature
>          Components: metrics
>    Affects Versions: 0.90.4
>         Environment: Java 6
>            Reporter: Eric Yang
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch, HBASE-4050-0.patch,
HBASE-4050-1.patch, HBASE-4050-2.patch, HBASE-4050-3.patch, HBASE-4050-5.patch, HBASE-4050-6.patch,
HBASE-4050-7.patch, HBASE-4050-8.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+, and it might
get removed in future Hadoop release.  Hence, HBase needs to revise the dependency of MetricsContext
to use Metrics2 framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message