hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6471) Performance regression caused by HBASE-4054
Date Tue, 31 Jul 2012 18:55:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426017#comment-13426017
] 

Lars Hofhansl commented on HBASE-6471:
--------------------------------------

The way we have HTablePool.PooledHTable extending HTable is actually quite "terrible".
For example append was not added to it, so for append it won't go through the delegate...
Which happens to be fine, because the delegate is not needed to begin with when PooledHTable
just extends HTable.

At the very least we should remove the delegate and just override close() and toString()..
or fix HBASE-5728.
                
> Performance regression caused by HBASE-4054
> -------------------------------------------
>
>                 Key: HBASE-6471
>                 URL: https://issues.apache.org/jira/browse/HBASE-6471
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.92.0
>            Reporter: Lars George
>            Priority: Critical
>             Fix For: 0.94.2
>
>
> The patch in HBASE-4054 switches the PooledHTable to extend HTable as opposed to implement
HTableInterface.
> Since HTable does not have an empty constructor, the patch added a call to the super()
constructor, which though does trigger the ZooKeeper and META scan, causing a considerable
delay. 
> With multiple threads using the pool in parallel, the first thread is holding up all
the subsequent ones, in effect it negates the whole reason we have a HTable pool.
> We should complete HBASE-5728, or alternatively add a protected, empty constructor the
HTable. I am +1 for the former.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message