hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6337) [MTTR] Remove renaming tmp log file in SplitLogManager
Date Mon, 09 Jul 2012 06:41:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409221#comment-13409221
] 

chunhui shen commented on HBASE-6337:
-------------------------------------

@ram
bq.If the region dir is deleted by CJ then in the current patch we will get IOException and
splitlog may be retried?
For this case, if region dir is deleted by CJ when we are appending data, we will get IOException
and splitlog would retry. In the next retry splitting, we won't split log for this region
through the following code:
HLogSplitter#getRegionSplitEditsPath
{code}
 if (!fs.exists(regiondir)) {
      LOG.info("This region's directory doesn't exist: "
          + regiondir.toString() + ". It is very likely that it was" +
          " already split so it's safe to discard those edits.");
      return null;
    }
{code}

bq.They were doing listAll and expecting a set of files? Now we are not doing that? Is it
ok?
This operation is used to list all the recovered.edits files in the tmp directory and move
them to region'dir, however now we don't split log to tmp directory, so no need to do that.
                
> [MTTR] Remove renaming tmp log file in SplitLogManager 
> -------------------------------------------------------
>
>                 Key: HBASE-6337
>                 URL: https://issues.apache.org/jira/browse/HBASE-6337
>             Project: HBase
>          Issue Type: Bug
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0, 0.94.2
>
>         Attachments: HBASE-6337v1.patch, HBASE-6337v2.patch, HBASE-6337v3.patch
>
>
> As HBASE-6309 mentioned, we also encounter problem of distributed-log-splitting take
much more time than matser-local-log-splitting because lots of SplitLogManager 's renaming
operations when finishing task.
> Could we try to remove renaming tmp log file in SplitLogManager through splitting log
to regions' recover.edits directory directly as the same as the master-local-log-splitting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message