hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6362) Enhance test-patch.sh script to recognize images / non-trunk patches
Date Tue, 10 Jul 2012 17:24:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410572#comment-13410572
] 

Zhihong Ted Yu commented on HBASE-6362:
---------------------------------------

I don't have control over the dialog that pops up for uploading patches.

Currently Hadoop QA only runs trunk test suite. Even if we're able to distinguish patches
for branches, we still need to filter out image files, log files and tar balls.

What if someone attaches the following ?
6311-94-ver1.txt
6311-0.92-version2.patch

If we want to inform contributors of new guideline, the guideline should be as simple as possible.

I prefer the first approach I outlined.
                
> Enhance test-patch.sh script to recognize images / non-trunk patches
> --------------------------------------------------------------------
>
>                 Key: HBASE-6362
>                 URL: https://issues.apache.org/jira/browse/HBASE-6362
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zhihong Ted Yu
>
> When user uploads logs / images / non-trunk patches, Hadoop QA would complain that the
file couldn't be applied as a patch (for trunk).
> We should make this script smarter by recognizing image files and non-trunk patches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message