hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6350) Some logging improvements for RegionServer bulk loading
Date Sat, 07 Jul 2012 10:34:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408616#comment-13408616
] 

Hadoop QA commented on HBASE-6350:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12535512/HBASE-6350.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's
current 4 warnings).

    -1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestZooKeeper

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2342//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2342//console

This message is automatically generated.
                
> Some logging improvements for RegionServer bulk loading
> -------------------------------------------------------
>
>                 Key: HBASE-6350
>                 URL: https://issues.apache.org/jira/browse/HBASE-6350
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HBASE-6350.patch
>
>
> The current logging in the bulk loading RPC call to a RegionServer lacks some info in
certain cases. For instance, I recently noticed that it is possible that IOException may be
caused during bulk load file transfer (copy) off of another FS and that during the same time
the client already times the socket out and thereby does not receive a thrown Exception back
remotely (HBase prints a ClosedChannelException for the IPC when it attempts to send the real
message, and hence the real cause is lost).
> Improvements around this kind of issue, wherein we could first log the IOException at
the RS before sending, and a few other wording improvements are present in my patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message