hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
Date Thu, 12 Jul 2012 14:08:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412814#comment-13412814
] 

stack commented on HBASE-5997:
------------------------------

On the first item, won't that be a seek each time we go for the firstKey in an empty file?
 It will be rare yes, but could be a pain if happened so would suggest a boolean flag for
whether or not we've done the first key check.

On the second item when we do the compare, are the offsets to where the key bytes start or
to where the key starts (with its length preample)?  For sure, we are comparing the row portions
of keys?

Thanks Anoop.

(@Lars Maybe its ok putting this into 0.94.2 or into second 0.94.1RC).
                
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
>                 Key: HBASE-5997
>                 URL: https://issues.apache.org/jira/browse/HBASE-5997
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 0.94.2
>
>         Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message