hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6331) Problem with HBCK mergeOverlaps
Date Thu, 12 Jul 2012 17:43:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412994#comment-13412994

Jimmy Xiang commented on HBASE-6331:

@Anoop, in hbck, the last endkey is changed to null, which is greater than all other keys.

Could you add a testcase to verify this is not a bug?

> Problem with HBCK mergeOverlaps
> -------------------------------
>                 Key: HBASE-6331
>                 URL: https://issues.apache.org/jira/browse/HBASE-6331
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.96.0, 0.94.2
>         Attachments: HBASE-6331_94.patch, HBASE-6331_Trunk.patch
> In HDFSIntegrityFixer#mergeOverlaps(), there is a logic to create the final range of
the region after the overlap.
> I can see one issue with this code
> {code}
>             if (RegionSplitCalculator.BYTES_COMPARATOR
>                     .compare(hi.getEndKey(), range.getSecond()) > 0) {
>               range.setSecond(hi.getEndKey());
>             }
> {code}
> Here suppose the regions include the end region for which the endKey will be empty, we
need to get finally the range with endkey as empty byte[]
> But as per the above logic it will see that any other key greater than the empty byte[]
and will set it.
> Finally the new region created will not get endkey as empty byte[]

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message