hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4072) Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
Date Sun, 15 Jul 2012 18:15:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414732#comment-13414732
] 

Harsh J commented on HBASE-4072:
--------------------------------

{quote}
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}

I assembled a package, ran a single node cluster with hbase-site.xml configured and a zoo.cfg
on the conf/ directory, pointing to a non-existent server. It seemed to start, which probably
meant it picked up the hbase-site.xml and ignored zoo.cfg as my patch intends to. But I can
add some tests, ideas?

bq. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's
current 4 warnings).

The additional javac warning is cause of the newly deprecated method being used (in the fallback
method). I could suppress it, but dunno if thats good to do (we should be removing usage of
that method by the next release after the one this goes into).

bq. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

In the report, none of the classes I've touched here seem to be reported.

{quote}
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
{quote}

The failing test passes for me on both trunk and with patch applied:

{code}
Running org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.11 sec
{code}
                
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4072
>                 URL: https://issues.apache.org/jira/browse/HBASE-4072
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.0
>            Reporter: stack
>            Assignee: Harsh J
>         Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name
for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections
is one IIRC)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message