hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6333) MemStoreScanner {kvsetAtCreation,snapshotAtCreation} should be private and not volatile
Date Fri, 06 Jul 2012 22:00:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408386#comment-13408386
] 

stack commented on HBASE-6333:
------------------------------

+1 on patch.... did it get committed?  (If set only on creation, can these be final?)
                
> MemStoreScanner {kvsetAtCreation,snapshotAtCreation} should be private and not volatile
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-6333
>                 URL: https://issues.apache.org/jira/browse/HBASE-6333
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-6333.patch
>
>
> I was looking over this code and was confused why these variables were volatile, as they
don't need to be [the constructor, which is the only place the variables are set, is already
protected by a lock].
> I doubt this makes much performance difference (I haven't measured); this is more of
a documentation difference to say nothing special is going on here :).
> https://issues.apache.org/jira/browse/HBASE-4485?focusedCommentId=13132733&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13132733
also talks about this, but it doesn't seem to have been implemented.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message