hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6334) TestImprovement for TestHRegion.testWritesWhileGetting
Date Sat, 07 Jul 2012 03:40:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408557#comment-13408557
] 

Jonathan Hsieh commented on HBASE-6334:
---------------------------------------

I think if we can make the pre-patch version fail 1 out of 5 times (or just run it longer
to make it fail), it might be sufficient.
                
> TestImprovement for TestHRegion.testWritesWhileGetting
> ------------------------------------------------------
>
>                 Key: HBASE-6334
>                 URL: https://issues.apache.org/jira/browse/HBASE-6334
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>
> Two improvements:
> 1. I was running testWritesWhileGetting on 0.90.6 (which lacks HBASE-4195) and I couldn't
get the 20% failures mentioned in the JIRA.  It was more like 1%.  So I increased the flush
frequency and it failed most of the time.
> 2.  The check on failure is wrong:
> {code}
> assertEquals(previousKV.getValue(), thisValue);
> {code}
> Since this is a byte array, we should use Bytes.compareTo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message