hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6327) HLog can be null when create table
Date Fri, 06 Jul 2012 00:04:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407616#comment-13407616
] 

Hadoop QA commented on HBASE-6327:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12535266/6327.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's
current 4 warnings).

    -1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2333//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2333//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2333//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2333//console

This message is automatically generated.
                
> HLog can be null when create table
> ----------------------------------
>
>                 Key: HBASE-6327
>                 URL: https://issues.apache.org/jira/browse/HBASE-6327
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ShiXing
>            Assignee: ShiXing
>         Attachments: 6327.txt, HBASE-6327-trunk-V1.patch, createTableFailedMaster.log
>
>
> As HBASE-4010 discussed, the HLog can be null.
> We have meet createTable failed because the no use hlog.
> When createHReagion, the HLog.LogSyncer is run sync(), in under layer it call the DFSClient.DFSOutputStream.sync().

> Then the hlog.closeAndDelete() was called,firstly the HLog.close() will interrupt the
LogSyncer, and interrupt DFSClient.DFSOutputStream.sync().The DFSClient.DFSOutputStream will
store the exception and throw it when we called DFSClient.close(). 
> The HLog.close() call the writer.close()/DFSClient.close() after interrupt the LogSyncer.
And there is no catch exception for the close().
> So the Master throw exception to the client. There is no need to throw this exception,
further, the hlog is no use.
> Our cluster is 0.90, the logs is attached, after "closing hlog writer", there is no log
for the createTable().
> The trunk and 0.92, 0.94, we used just one hlog, and if the exception happends, the client
will got createTable failed, but indeed ,we expect all the regions for the table can also
be assigned.
> I will give the patch for this later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message