hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6400) Add getMasterAdmin() and getMasterMonitor() to HConnection
Date Tue, 17 Jul 2012 20:18:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416553#comment-13416553
] 

Hadoop QA commented on HBASE-6400:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12536866/6400-v2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's
current 4 warnings).

    -1 findbugs.  The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2394//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2394//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2394//console

This message is automatically generated.
                
> Add getMasterAdmin() and getMasterMonitor() to HConnection
> ----------------------------------------------------------
>
>                 Key: HBASE-6400
>                 URL: https://issues.apache.org/jira/browse/HBASE-6400
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.96.0
>
>         Attachments: 6400-v2.patch, HBASE-6400_v1.patch
>
>
> HConnection used to have getMaster() which returns HMasterInterface, but after HBASE-6039
it has been removed. I think we need to expose HConnection.getMasterAdmin() and getMasterMonitor()
a la HConnection.getAdmin(), and getClient(). 
> HConnectionImplementation has getKeepAliveMasterAdmin() but, I see no reason to leak
keep alive classes to upper layers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message