Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 20 Jun 2012 21:17:43 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <945171111.36099.1340227063350.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1537201517.34267.1340205462898.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Comment Edited] (HBASE-6244) [REST] Result generators do
 not need to query table schema
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397877#comment-13397877 ] 

Andrew Purtell edited comment on HBASE-6244 at 6/20/12 9:17 PM:
----------------------------------------------------------------

Committed trivial patch to trunk, 0.94, and 0.92 branches. All unit tests pass locally for trunk. All REST unit tests pass locally for 0.94.

Many thanks for pointing out this issue, Xing!

Edit: ... and REST tests pass for 0.92.
                
      was (Author: apurtell):
    Committed trivial patch to trunk, 0.94, and 0.92 branches. All unit tests pass locally for trunk. All REST unit tests pass locally for 0.94.

Many thanks for pointing out this issue, Xing!
                  
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
>                 Key: HBASE-6244
>                 URL: https://issues.apache.org/jira/browse/HBASE-6244
>             Project: HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.92.2, 0.96.0, 0.94.1
>            Reporter: Xing Shi
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info. 
> {code}
>       if (rowspec.hasColumns()) {
>         //addColumn for get or scan
>       } else {
>         for (HColumnDescriptor family: 
>             table.getTableDescriptor().getFamilies()) {
>           scan/get.addFamily(family.getName());
>         }
>       }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira