Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6F54CE08 for ; Tue, 5 Jun 2012 01:01:38 +0000 (UTC) Received: (qmail 68963 invoked by uid 500); 5 Jun 2012 01:01:38 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 68911 invoked by uid 500); 5 Jun 2012 01:01:38 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68847 invoked by uid 99); 5 Jun 2012 01:01:38 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2012 01:01:38 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 08E73142864 for ; Tue, 5 Jun 2012 01:01:38 +0000 (UTC) Date: Tue, 5 Jun 2012 01:01:38 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: <920335421.37180.1338858098038.JavaMail.jiratomcat@issues-vm> In-Reply-To: <293088236.35474.1338833543301.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HBASE-6158) Data loss if the words 'merges' or 'splits' are used as Column Family name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289037#comment-13289037 ] Hudson commented on HBASE-6158: ------------------------------- Integrated in HBase-0.94-security #34 (See [https://builds.apache.org/job/HBase-0.94-security/34/]) HBASE-6158 Data loss if the words 'merges' or 'splits' are used as Column Family name (Revision 1346096) Result = SUCCESS stack : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java > Data loss if the words 'merges' or 'splits' are used as Column Family name > -------------------------------------------------------------------------- > > Key: HBASE-6158 > URL: https://issues.apache.org/jira/browse/HBASE-6158 > Project: HBase > Issue Type: Bug > Components: master, regionserver > Affects Versions: 0.94.0 > Reporter: Aditya Kishore > Assignee: Aditya Kishore > Fix For: 0.92.2, 0.94.1 > > Attachments: HBASE-6158_94.patch, HBASE-6158_trunk.patch > > > If a table is creates with either 'merges' or 'splits' as one of the Column Family name it can never be flushed to the disk even though the table creation (and data population) succeeds. > The reason for this is that these two are used as temporary directory names inside the region folder or merge and splits respectively and hence conflicts with the directories created for CF with same name. > A simple fix would be to uses ".merges' and ".splits" as the working folder (patch attached). This will also be consistent with other work folder names. An alternate fix would be to declare these words (and other similar) as reserve words and throw exception when they are used. However, I do find the alternate approach as unnecessarily restrictive. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira