Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57CB49BE4 for ; Tue, 26 Jun 2012 10:23:48 +0000 (UTC) Received: (qmail 93475 invoked by uid 500); 26 Jun 2012 10:23:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 93395 invoked by uid 500); 26 Jun 2012 10:23:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 93348 invoked by uid 99); 26 Jun 2012 10:23:47 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jun 2012 10:23:47 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id E08D314035F for ; Tue, 26 Jun 2012 10:23:46 +0000 (UTC) Date: Tue, 26 Jun 2012 10:23:46 +0000 (UTC) From: "Jieshan Bean (JIRA)" To: issues@hbase.apache.org Message-ID: <6844362.55740.1340706226922.JavaMail.jiratomcat@issues-vm> In-Reply-To: <870713301.4379.1339450663357.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (HBASE-6200) KeyComparator.compareWithoutRow can be wrong when families have the same prefix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jieshan Bean updated HBASE-6200: -------------------------------- Attachment: (was: HBASE-6200-90.patch) > KeyComparator.compareWithoutRow can be wrong when families have the same prefix > ------------------------------------------------------------------------------- > > Key: HBASE-6200 > URL: https://issues.apache.org/jira/browse/HBASE-6200 > Project: HBase > Issue Type: Bug > Affects Versions: 0.90.6, 0.92.1, 0.94.0 > Reporter: Jean-Daniel Cryans > Assignee: Jieshan Bean > Priority: Blocker > Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1 > > Attachments: 6200-trunk-v2.patch, HBASE-6200-90-v2.patch, HBASE-6200-92-v2.patch, HBASE-6200-94-v2.patch, PerformanceTestCase-6200-94.patch > > > As reported by Desert Rose on IRC and on the ML, {{Result}} has a weird behavior when some families share the same prefix. He posted a link to his code to show how it fails, http://pastebin.com/7TBA1XGh > Basically {{KeyComparator.compareWithoutRow}} doesn't differentiate families and qualifiers so "f:a" is said to be bigger than "f1:", which is false. Then what happens is that the KVs are returned in the right order from the RS but then doing {{Result.binarySearch}} it uses {{KeyComparator.compareWithoutRow}} which has a different sorting so the end result is undetermined. > I added some debug and I can see that the data is returned in the right order but {{Arrays.binarySearch}} returned the wrong KV, which is then verified agains the passed family and qualifier which fails so null is returned. > I don't know how frequent it is for users to have families with the same prefix, but those that do have that and that use those families at the same time will have big correctness issues. This is why I mark this as a blocker. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira