Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 22 Jun 2012 00:40:42 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <643744488.42287.1340325642746.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <148905787.11704.1332548966861.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5630) hbck should disable the balancer
 using synchronousBalanceSwitch.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399035#comment-13399035 ] 

Hadoop QA commented on HBASE-5630:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532970/HBASE-5630.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2218//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2218//console

This message is automatically generated.
                
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
>                 Key: HBASE-5630
>                 URL: https://issues.apache.org/jira/browse/HBASE-5630
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira