Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 28 Jun 2012 17:28:46 +0000 (UTC)
From: "Zhihong Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <41674709.67458.1340904526287.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1112620452.23707.1339990602704.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6226) move DataBlockEncoding and related
 classes to hbase-common module
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403254#comment-13403254 ] 

Zhihong Ted Yu commented on HBASE-6226:
---------------------------------------

@Matt:
You should have selected hbase-git as the Repository.

The change to prepareDecoding() looks good.
{code}
+   * @param block HFile block object
+   * @param onDiskBlock on disk bytes to be decoded
+   * @param offset data start offset in onDiskBlock
+   * @throws IOException
+   */
+  public void prepareDecoding(int onDiskSizeWithoutHeader, int uncompressedSizeWithoutHeader,
{code}
The javadoc doesn't match parameters.
In HFileBlock.java, there're some white spaces.

Here is one review request: https://reviews.apache.org/r/5643/
Feel free to create your own.
                
> move DataBlockEncoding and related classes to hbase-common module
> -----------------------------------------------------------------
>
>                 Key: HBASE-6226
>                 URL: https://issues.apache.org/jira/browse/HBASE-6226
>             Project: HBase
>          Issue Type: Improvement
>          Components: io, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6226-v1.patch, HBASE-6226-v2.patch
>
>
> In order to isolate the implementation details of HBASE-4676 (PrefixTrie encoding) and other DataBlockEncoders by putting them in modules, this pulls up the DataBlockEncoding related interfaces into hbase-common.
> No tests are moved in this patch.  The only notable change was trimming a few dependencies on HFileBlock which adds dependencies to much of the regionserver.
> The test suite passes locally for me.
> I tried to keep it as simple as possible... let me know if there are any concerns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira