Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E01A398F4 for ; Sat, 23 Jun 2012 18:23:46 +0000 (UTC) Received: (qmail 63325 invoked by uid 500); 23 Jun 2012 18:23:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 63261 invoked by uid 500); 23 Jun 2012 18:23:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 63219 invoked by uid 99); 23 Jun 2012 18:23:46 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Jun 2012 18:23:46 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 7A0371416E9 for ; Sat, 23 Jun 2012 18:23:46 +0000 (UTC) Date: Sat, 23 Jun 2012 18:23:46 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: <258122906.47943.1340475826501.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1574379615.25609.1338533843346.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HBASE-6146) Disabling of Catalog tables should not be allowed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400014#comment-13400014 ] Hudson commented on HBASE-6146: ------------------------------- Integrated in HBase-0.94-security #37 (See [https://builds.apache.org/job/HBase-0.94-security/37/]) HBASE-6146 Disabling of Catalog tables should not be allowed (Anoop) (Revision 1347718) Result = SUCCESS ramkrishna : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java > Disabling of Catalog tables should not be allowed > ------------------------------------------------- > > Key: HBASE-6146 > URL: https://issues.apache.org/jira/browse/HBASE-6146 > Project: HBase > Issue Type: Bug > Components: client > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 0.96.0, 0.94.1 > > Attachments: HBASE-6146_94.patch, HBASE-6146_Trunk.patch > > > HBaseAdmin#disableTable() when called with META or ROOT table, it will pass the disable instruction to Master and table is actually getting disabled. Later this API call will fail as there is a call to HBaseAdmin#isTableDisabled() which is having a check like isLegalTableName(tableName).So this call makes the catalog table to be in disabled state. > We can have same kind of isLegalTableName(tableName) checks in disableTable() and enableTable() APIs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira