Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 88BD991AB for ; Tue, 12 Jun 2012 17:08:43 +0000 (UTC) Received: (qmail 78764 invoked by uid 500); 12 Jun 2012 17:08:43 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 78707 invoked by uid 500); 12 Jun 2012 17:08:43 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 78697 invoked by uid 99); 12 Jun 2012 17:08:43 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jun 2012 17:08:43 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 3FF3D142863 for ; Tue, 12 Jun 2012 17:08:43 +0000 (UTC) Date: Tue, 12 Jun 2012 17:08:43 +0000 (UTC) From: "Zhihong Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: <189487896.8431.1339520923265.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1757121918.21204.1336040212485.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5924) In the client code, don't wait for all the requests to be executed before resubmitting a request in error. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293778#comment-13293778 ] Zhihong Ted Yu commented on HBASE-5924: --------------------------------------- I don't have further comments. Thanks > In the client code, don't wait for all the requests to be executed before resubmitting a request in error. > ---------------------------------------------------------------------------------------------------------- > > Key: HBASE-5924 > URL: https://issues.apache.org/jira/browse/HBASE-5924 > Project: HBase > Issue Type: Improvement > Components: client > Affects Versions: 0.96.0 > Reporter: nkeywal > Assignee: nkeywal > Fix For: 0.96.0 > > Attachments: 5924.v11.patch, 5924.v14.patch, 5924.v5.patch, 5924.v9.patch > > > The client (in the function HConnectionManager#processBatchCallback) works in two steps: > - make the requests > - collect the failures and successes and prepare for retry > It means that when there is an immediate error (region moved, split, dead server, ...) we still wait for all the initial requests to be executed before submitting again the failed request. If we have a scenario with all the requests taking 5 seconds we have a final execution time of: 5 (initial requests) + 1 (wait time) + 5 (final request) = 11s. > We could improve this by analyzing immediately the results. This would lead us, for the scenario mentioned above, to 6 seconds. > So we could have a performance improvement of nearly 50% in many cases, and much more than 50% if the request execution time is different. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira