Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 29 Jun 2012 20:21:44 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1654053333.73115.1341001304629.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1094220754.9501.1339539222795.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6203) Create hbase-it module
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404170#comment-13404170 ] 

Enis Soztutar commented on HBASE-6203:
--------------------------------------

@Jesse,
Agreed. We now have a switch for every module, but -Donly-integration-tests might not be necessary since you can do {{cd hbase-it;mvn-verify}}. With maven modules, I think the standard way to only execute one module is to cd into that module and execute. I'll add that to the doc. Do you think that would be enough?

@Stack 
Thanks a lot for the docs, I totally missed that. 
failsafe is basically a fork of surefire, which only adds pre- and post-integration-tests targets. We are not using them right now, but we can make use of those targets, for recovering the cluster after the test for example. I totally share your doubts about this failsafe/surefire thing, but I do not know of any better solution. Suggestions welcome :) 

mvn verify now executes the classes {{IntegrationTestXXX}} as unit tests. There is also an IntegrationTestsDriver class in the patch at HBASE-6241, which is executed by: 
{code}
bin/hbase --config org.apache.hadoop.hbase.IntegrationTestsDriver
{code}

I'll open another subtask for HBASE-6201, for making {{mvn verify}} to work with real clusters. I have checked how bigtop does it, and it seems they have: 
{code}
 bigtop-tests/test-artifacts/  --> contains actual test code
 bigtop-tests/test-execution/  --> contains code + configuration for executing the tests
{code}

Especially, if you look into {{bigtop-tests/test-execution/smokes/hbase/pom.xml}}, it passes HBASE_HOME, HBASE_CONF_DIR, etc from evn to failsafe. It works for bigtop, so I think we can make it work for our cases as well.  

                
> Create hbase-it module
> ----------------------
>
>                 Key: HBASE-6203
>                 URL: https://issues.apache.org/jira/browse/HBASE-6203
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6203_v1.patch, it-doc.txt
>
>
> Create hbase-it, as per parent issue, and re-introduce HBASE-4454

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira