Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C246CC69 for ; Tue, 26 Jun 2012 18:35:45 +0000 (UTC) Received: (qmail 10041 invoked by uid 500); 26 Jun 2012 18:35:44 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 9985 invoked by uid 500); 26 Jun 2012 18:35:44 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 9963 invoked by uid 99); 26 Jun 2012 18:35:44 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jun 2012 18:35:44 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 2246814283D for ; Tue, 26 Jun 2012 18:35:44 +0000 (UTC) Date: Tue, 26 Jun 2012 18:35:44 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: <1277900552.57714.1340735744142.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1501700190.46145.1340408022705.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HBASE-6263) Use default mode for HBase Thrift gateway if not specified MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401589#comment-13401589 ] Hadoop QA commented on HBASE-6263: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533517/HBASE-6263-0.94.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2263//console This message is automatically generated. > Use default mode for HBase Thrift gateway if not specified > ---------------------------------------------------------- > > Key: HBASE-6263 > URL: https://issues.apache.org/jira/browse/HBASE-6263 > Project: HBase > Issue Type: Bug > Components: thrift > Affects Versions: 0.94.0, 0.96.0 > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Minor > Labels: noob > Attachments: HBASE-6263-0.94.patch, HBASE-6263.patch > > > The Thrift gateway should start with a default mode if one is not selected. Currently, instead we see: > {noformat} > Exception in thread "main" java.lang.AssertionError: Exactly one option out of [-hsha, -nonblocking, -threadpool, -threadedselector] has to be specified > at org.apache.hadoop.hbase.thrift.ThriftServerRunner$ImplType.setServerImpl(ThriftServerRunner.java:201) > at org.apache.hadoop.hbase.thrift.ThriftServer.processOptions(ThriftServer.java:169) > at org.apache.hadoop.hbase.thrift.ThriftServer.doMain(ThriftServer.java:85) > at org.apache.hadoop.hbase.thrift.ThriftServer.main(ThriftServer.java:192) > {noformat} > See also BIGTOP-648. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira