Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 15 Jun 2012 20:32:43 +0000 (UTC)
From: "M. Chen (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1037695955.20030.1339792363097.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <777358716.19330.1339781322559.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6217) reduce overhead of maintaing
 get/next size metric
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295908#comment-13295908 ] 

M. Chen commented on HBASE-6217:
--------------------------------

Diff uploaded at https://reviews.facebook.net/differential/diff/11895
                
> reduce overhead of maintaing get/next size metric
> -------------------------------------------------
>
>                 Key: HBASE-6217
>                 URL: https://issues.apache.org/jira/browse/HBASE-6217
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Kannan Muthukkaruppan
>            Assignee: M. Chen
>         Attachments: StoreScanner.java
>
>
> [Forked off this specific issue as a separate JIRA from HBASE-6066].
> Reduce overhead of "size metric" maintained in StoreScanner.next().
> {code}
> if (metric != null) {
>      HRegion.incrNumericMetric(this.metricNamePrefix + metric,
>                                copyKv.getLength());
>   }
>   results.add(copyKv);
> {code}
> A single call to next() might fetch a lot of KVs. We can first add up the size of those KVs in a local variable and then in a finally clause increment the metric one shot, rather than updating AtomicLongs for each KV.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira