hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5630) hbck should disable the balancer using synchronousBalanceSwitch.
Date Fri, 22 Jun 2012 02:11:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399077#comment-13399077
] 

Zhihong Ted Yu commented on HBASE-5630:
---------------------------------------

Patch looks good.
{code}
+    return setBalancerRunning(b,false);
{code}
Please insert space after comma.
{code}
+  public SetBalancerRunningResponse setBalancerRunning(RpcController controller, SetBalancerRunningRequest
req)
{code}
Wrap long line above.
                
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
>                 Key: HBASE-5630
>                 URL: https://issues.apache.org/jira/browse/HBASE-5630
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable
to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message