hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6205) Support an option to keep data of dropped table for some time
Date Thu, 14 Jun 2012 06:27:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294833#comment-13294833
] 

Hadoop QA commented on HBASE-6205:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532035/HBASE-6205v2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestTrashTableCleaner

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2167//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2167//console

This message is automatically generated.
                
> Support an option to keep data of dropped table for some time
> -------------------------------------------------------------
>
>                 Key: HBASE-6205
>                 URL: https://issues.apache.org/jira/browse/HBASE-6205
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6205.patch, HBASE-6205v2.patch
>
>
> User may drop table accidentally because of error code or other uncertain reasons.
> Unfortunately, it happens in our environment because one user make a mistake between
production cluster and testing cluster.
> So, I just give a suggestion, do we need to support an option to keep data of dropped
table for some time, e.g. 1 day
> In the patch:
> We make a new dir named .trashtables in the rood dir.
> In the DeleteTableHandler, we move files in dropped table's dir to trash table dir instead
of deleting them directly.
> And Create new class TrashTableCleaner which will clean dropped tables if it is time
out with a period check.
> Default keep time for dropped tables is 1 day, and check period is 1 hour.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message