hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6012) Handling RegionOpeningState for bulk assign since SSH using
Date Thu, 07 Jun 2012 04:53:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290790#comment-13290790
] 

ramkrishna.s.vasudevan commented on HBASE-6012:
-----------------------------------------------

@Chunhui
Minor comments
It should be 'processAlreadyOpenedRegion', i think you forgot to add 'e' in 'opened'. Currently
it is processAlreadyOpendRegion
'Reassigning region with rs=' should be 'Reassigning region with rs =' (a space is needed).

Any specific reason for making this change now?
{code}
for (HRegionInfo region : reassigningRegions) {
        assign(region, true, true);
      }
{code}

{code}
// Failed opening this region, reassign it
              assign(regions.get(i), true, true);
{code}
before doing this can we call getRegionPlan() passing the current server on which failure
happened so that i can be excluded.(May not be mandatory).

Overall looks good. Thanks Chunhui.


                
> Handling RegionOpeningState for bulk assign since SSH using
> -----------------------------------------------------------
>
>                 Key: HBASE-6012
>                 URL: https://issues.apache.org/jira/browse/HBASE-6012
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6012.patch, HBASE-6012v2.patch, HBASE-6012v3.patch, HBASE-6012v4.patch
>
>
> Since HBASE-5914, we using bulk assign for SSH
> But in the bulk assign case if we get an ALREADY_OPENED case there is no one to clear
the znode created by bulk assign. 
> Another thing, when RS opening a list of regions, if one region is already in transition,
it will throw RegionAlreadyInTransitionException and stop opening other regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message