hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5630) hbck should disable the balancer using synchronousBalanceSwitch.
Date Fri, 22 Jun 2012 03:54:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399101#comment-13399101
] 

Anoop Sam John commented on HBASE-5630:
---------------------------------------

{code}
finally {
-      admin.balanceSwitch(oldBalancer);
+      admin.setBalancerRunning(oldBalancer,true);
}
{code}
This change of code is necessary? Any way balancer turned off before. So no problem with old
code.  Any way turn ON balancer in SYNC way might not have any difference.

setBalancerRunning(final boolean on, final boolean synchronous)
Here do we better go with similar API in HMaster? We already have one API which sets the state
in ASYNC way [HBaseAdmin#balanceSwitch(final boolean b)] Similar way API which takes only
one arg is enough?
Or else we keep the API in HBaseAdmin with 2 params and may be deprecate the old API with
one param?
                
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
>                 Key: HBASE-5630
>                 URL: https://issues.apache.org/jira/browse/HBASE-5630
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable
to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message