hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6012) Handling RegionOpeningState for bulk assign since SSH using
Date Mon, 11 Jun 2012 09:37:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292711#comment-13292711

chunhui shen commented on HBASE-6012:

// Can be a socket timeout, EOF, NoRouteToHost, etc
LOG.info("Unable to communicate with the region server in order" +
           " to assign regions", e);
-      return false;
+      // Server may already get RPC
+      return true;
bq.What was the reasoning behind the above change ?

At first, I think we can't ensure regionserver not receive the OPENREGION rpc, in order to
prevent double assign, so I make this change. Also here could return false because of protecting
through single assign.

{code}throw new RegionAlreadyInTransitionException("Received:" + currentAction +
        " for the region:" + region.getRegionNameAsString() +
        " ,which we are already trying to " +
        (openAction ? OPEN : CLOSE)+ ".");

bq.Please add some sentence for the log above.

We have added message about it in RegionAlreadyInTransitionException, so I think we needn't
add again.

For other comments, I update it in patch v6.


> Handling RegionOpeningState for bulk assign since SSH using
> -----------------------------------------------------------
>                 Key: HBASE-6012
>                 URL: https://issues.apache.org/jira/browse/HBASE-6012
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0
>         Attachments: HBASE-6012.patch, HBASE-6012v2.patch, HBASE-6012v3.patch, HBASE-6012v4.patch,
> Since HBASE-5914, we using bulk assign for SSH
> But in the bulk assign case if we get an ALREADY_OPENED case there is no one to clear
the znode created by bulk assign. 
> Another thing, when RS opening a list of regions, if one region is already in transition,
it will throw RegionAlreadyInTransitionException and stop opening other regions.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message