hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6162) Move KeyValue to hbase-common module
Date Mon, 18 Jun 2012 20:09:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396205#comment-13396205

Jesse Yates commented on HBASE-6162:

bq. Jesse and I are proposing that we put the tests that would go in hbase-common/src/test/java
into hbase-common/src/main/java so they becomes visible downstream.

Not quite. I'd rather see the test _utilities_ go into src/main, for downstream visibility,
but keep the tests themselves in src/test. I don't think we actually do any test heirarchy,
so this shouldn't be a problem. If we do have some inheritance, then those classes will need
to be together (same module), but this should be rare. 

hbase-tests might then have the testing utils in src/main and the tests in src/tests

FWIW, you can hack the locations to look for test classes with the <testResources\>
tag in the pom. Its not pretty, but does provide a route to putting test classes in src/main/test/
> Move KeyValue to hbase-common module
> ------------------------------------
>                 Key: HBASE-6162
>                 URL: https://issues.apache.org/jira/browse/HBASE-6162
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>         Attachments: HBASE-6162-v1.patch, HBASE-6162-v2.patch, HBASE-6162-v3.patch, HBASE-6162-v4.patch,
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is specifically necessary
to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to HConstants

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message