hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6241) HBaseCluster interface for interacting with the cluster from system tests
Date Wed, 27 Jun 2012 20:51:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402544#comment-13402544
] 

Zhihong Ted Yu commented on HBASE-6241:
---------------------------------------

{code}
+   * @return whether we are interacting with a real cluster as opposed to and in-process
mini
{code}
'and' -> 'an'

For HBaseClusterManager, I see enum STATUS but don't see method which issues that command.

For HBaseTestingUtility.java:
{code}
+    } catch (Exception ex) {
+      throw new RuntimeException(ex);
+    }
{code}
The above doesn't seem necessary.

For RealHBaseCluster.java, please add license.

For waitForActiveAndReadyMaster():
{code}
+      } catch (MasterNotRunningException m) {
+        LOG.warn("Master not started yet " + m);
{code}
Does it make sense to introduce timeout since loop may wait indefinitely.
                
> HBaseCluster interface for interacting with the cluster from system tests 
> --------------------------------------------------------------------------
>
>                 Key: HBASE-6241
>                 URL: https://issues.apache.org/jira/browse/HBASE-6241
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: HBASE-6241_v0.2.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual
clusters. 
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system
tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message