hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kannan Muthukkaruppan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6217) reduce overhead of maintaing get/next size metric
Date Sat, 16 Jun 2012 04:43:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296105#comment-13296105
] 

Kannan Muthukkaruppan commented on HBASE-6217:
----------------------------------------------

@ Ted: The patch is wrt to 89-fb.

@ Michael: Can you create a revision for your diff? Go to the https://reviews.facebook.net/differential/diff/11907
URL, and then hit "Continue" to create a revision, and fill in the details like reviewers.
To the description, add [89-fb] [HBASE-6217] tags, and add JIRA to the CC on the review.
                
> reduce overhead of maintaing get/next size metric
> -------------------------------------------------
>
>                 Key: HBASE-6217
>                 URL: https://issues.apache.org/jira/browse/HBASE-6217
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Kannan Muthukkaruppan
>            Assignee: M. Chen
>              Labels: patch
>         Attachments: jira-6217.patch
>
>
> [Forked off this specific issue as a separate JIRA from HBASE-6066].
> Reduce overhead of "size metric" maintained in StoreScanner.next().
> {code}
> if (metric != null) {
>      HRegion.incrNumericMetric(this.metricNamePrefix + metric,
>                                copyKv.getLength());
>   }
>   results.add(copyKv);
> {code}
> A single call to next() might fetch a lot of KVs. We can first add up the size of those
KVs in a local variable and then in a finally clause increment the metric one shot, rather
than updating AtomicLongs for each KV.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message