hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5953) Expose the current state of the balancerSwitch
Date Thu, 21 Jun 2012 22:05:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398920#comment-13398920
] 

Hadoop QA commented on HBASE-5953:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532934/HBASE-5953-v2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.security.access.TestAccessController

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2211//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2211//console

This message is automatically generated.
                
> Expose the current state of the balancerSwitch
> ----------------------------------------------
>
>                 Key: HBASE-5953
>                 URL: https://issues.apache.org/jira/browse/HBASE-5953
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.96.0
>            Reporter: David S. Wang
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5953-v2.patch, HBASE-5953-v2.patch, HBASE-5953.patch
>
>
> The balancerSwitch as in both 0.90 and 0.92.1 is implemented in such a way that it is
impossible to retrieve its value without changing it:
> /**
> Turn the load balancer on or off.
> @param b If true, enable balancer. If false, disable balancer.
> @return Previous balancer value
> */
> public boolean balanceSwitch(final boolean b);
> It would be nice to have a way to just get the current state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message