hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6162) Move KeyValue to hbase-common module
Date Thu, 07 Jun 2012 01:31:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290682#comment-13290682
] 

Jesse Yates commented on HBASE-6162:
------------------------------------

@stack - yup, that's what I was going on about in the comments in the poms. Essentially, it
doesn't build the tests jar for commons until the package phase, which doesn't get reached
if you just do a "test-compile" (or just test). Therefore, you aren't going to see the classes
in hbase-common/src/test in hbase-server. There are three ways around this.

(1) Move the test classes to needed by other modules to the hbase-common/src/main/java/...{package}/test.
Basically, just append test to their package names. This separates out the test oriented class
from the regular ones, but still makes it easy to get them when running tests
(2) Always run tests by doing mvn package. This sucks because you need to do a lot more work
for testing.
(3) Fix that maven issue. A ton of work and then everyone needs to use the patched maven.
Probably the worst option.

I'm in favor of just doing (1). Its pretty simple, doesn't clutter the code too much, and
doesn't require a ton of work.
                
> Move KeyValue to hbase-common module
> ------------------------------------
>
>                 Key: HBASE-6162
>                 URL: https://issues.apache.org/jira/browse/HBASE-6162
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6162-v1.patch
>
>
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is specifically necessary
to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to HConstants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message