hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6219) New UI elements may request external resources
Date Tue, 26 Jun 2012 03:58:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401148#comment-13401148
] 

Hadoop QA commented on HBASE-6219:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12533415/HBASE-6219-0.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2253//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2253//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2253//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2253//console

This message is automatically generated.
                
> New UI elements may request external resources
> ----------------------------------------------
>
>                 Key: HBASE-6219
>                 URL: https://issues.apache.org/jira/browse/HBASE-6219
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Andrew Purtell
>            Assignee: Elliott Clark
>            Priority: Blocker
>         Attachments: HBASE-6219-0.patch
>
>
> After HBASE-6135, the UI may, depending on browser version, attempt to pull in external
resources, e.g. from MasterStatusTmpl.jamon:
> {code}
>     <!--[if lt IE 9]>
>       <script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
>     <![endif]-->
> {code}
> This won't work if the UI is viewed in a restricted environment. Also, pulling external
resources from Googlecode / SVN like this seems not a good practice, those can change at any
given third party checkin.
> Rather, we should pull in any resources needed into our /static/ ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message