hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Corgan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6226) move DataBlockEncoding and related classes to hbase-common module
Date Thu, 28 Jun 2012 05:22:44 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matt Corgan updated HBASE-6226:
-------------------------------

    Attachment: HBASE-6226-v2.patch

Trying to post the v2 patch to reviews.apache.org, i get: 
{quote}
Something broke! (Error 500)

It appears something broke when you tried to go to here. This is either a bug in Review Board
or a server configuration error. Please report this to your administrator.
{quote}

The patch was generated from the project root directory, so is "/" what i should be entering
for the "Base Directory"?

Any suggestions for getting around that?


I believe the only code modification (besides moving files) is in HFileBlock:1731, which is
line 2504 of the v2 patch.


                
> move DataBlockEncoding and related classes to hbase-common module
> -----------------------------------------------------------------
>
>                 Key: HBASE-6226
>                 URL: https://issues.apache.org/jira/browse/HBASE-6226
>             Project: HBase
>          Issue Type: Improvement
>          Components: io, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>         Attachments: HBASE-6226-v1.patch, HBASE-6226-v2.patch
>
>
> In order to isolate the implementation details of HBASE-4676 (PrefixTrie encoding) and
other DataBlockEncoders by putting them in modules, this pulls up the DataBlockEncoding related
interfaces into hbase-common.
> No tests are moved in this patch.  The only notable change was trimming a few dependencies
on HFileBlock which adds dependencies to much of the regionserver.
> The test suite passes locally for me.
> I tried to keep it as simple as possible... let me know if there are any concerns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message