hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6296) Refactor EventType to track its own ExecutorService type
Date Sat, 30 Jun 2012 16:34:42 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jesse Yates updated HBASE-6296:
-------------------------------

    Attachment: java_hbase-6296-v0.patch

Attaching simple version.

Causes a slight overhead increase (a handful of pointers), but makes the code much more managable.
Alternatively, could just move the switch from ExecutorService into the method in EventHandler,
but that would loose all the nice OO going on in the current patch.
                
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
>                 Key: HBASE-6296
>                 URL: https://issues.apache.org/jira/browse/HBASE-6296
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService
for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This
means is you add an new event type, you will also have to change the executorservice file,
if for nothing but to add the executor type. Instead the EventType should just be able to
keep track of which executor it should use.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message