hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6219) New UI elements may request external resources
Date Fri, 15 Jun 2012 23:06:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295996#comment-13295996
] 

Elliott Clark commented on HBASE-6219:
--------------------------------------

Pulling those from google code is pretty standard web practice (this and jquery are very popular
things to pull from google's server).  They are cached on most machines so it makes things
faster.  

However your point about restricted environments is still a concern.  I didn't do it in the
initial patch since it's dual licensed and I didn't know what the rules around that were.
                
> New UI elements may request external resources
> ----------------------------------------------
>
>                 Key: HBASE-6219
>                 URL: https://issues.apache.org/jira/browse/HBASE-6219
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Priority: Minor
>
> After HBASE-6135, the UI may, depending on browser version, attempt to pull in external
resources, e.g. from MasterStatusTmpl.jamon:
> {code}
>     <!--[if lt IE 9]>
>       <script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
>     <![endif]-->
> {code}
> This won't work if the UI is viewed in a restricted environment. Also, pulling external
resources from Googlecode / SVN like this seems not a good practice, those can change at any
given third party checkin.
> Rather, we should pull in any resources needed into our /static/ ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message