hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6158) Data loss if the words 'merges' or 'splits' are used as Column Family name
Date Mon, 04 Jun 2012 19:24:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288836#comment-13288836
] 

Hadoop QA commented on HBASE-6158:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530831/HBASE-6158_trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.coprocessor.TestClassLoading

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2101//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2101//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2101//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2101//console

This message is automatically generated.
                
> Data loss if the words 'merges' or 'splits' are used as Column Family name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-6158
>                 URL: https://issues.apache.org/jira/browse/HBASE-6158
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.94.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>             Fix For: 0.92.2, 0.94.1
>
>         Attachments: HBASE-6158_94.patch, HBASE-6158_trunk.patch
>
>
> If a table is creates with either 'merges' or 'splits' as one of the Column Family name
it can never be flushed to the disk even though the table creation (and data population) succeeds.
> The reason for this is that these two are used as temporary directory names inside the
region folder or merge and splits respectively and hence conflicts with the directories created
for CF with same name.
> A simple fix would be to uses ".merges' and ".splits" as the working folder (patch attached).
This will also be consistent with other work folder names. An alternate fix would be to declare
these words (and other similar) as reserve words and throw exception when they are used. However,
I do find the alternate approach as unnecessarily restrictive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message