hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Bautin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6226) move DataBlockEncoding and related classes to hbase-common module
Date Mon, 25 Jun 2012 19:57:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400830#comment-13400830
] 

Mikhail Bautin commented on HBASE-6226:
---------------------------------------

Hi Matt,

The module breakdown you have described makes sense. Unfortunately, I can't see much from
the patch because a lot of files are being moved around. Would you mind posting it at https://reviews.facebook.com?
You need to run "mvn -Darc initialize", then (assuming you have a local git-svn checkout)
run "arc diff --only" when your changes correspond to the latest local commit, copy-paste
the URL arc gives you into the browser, and fill out some fields such as title and summary.

Thanks,
Mikhail

                
> move DataBlockEncoding and related classes to hbase-common module
> -----------------------------------------------------------------
>
>                 Key: HBASE-6226
>                 URL: https://issues.apache.org/jira/browse/HBASE-6226
>             Project: HBase
>          Issue Type: Improvement
>          Components: io, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>         Attachments: HBASE-6226-v1.patch
>
>
> In order to isolate the implementation details of HBASE-4676 (PrefixTrie encoding) and
other DataBlockEncoders by putting them in modules, this pulls up the DataBlockEncoding related
interfaces into hbase-common.
> No tests are moved in this patch.  The only notable change was trimming a few dependencies
on HFileBlock which adds dependencies to much of the regionserver.
> The test suite passes locally for me.
> I tried to keep it as simple as possible... let me know if there are any concerns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message