hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Corgan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6162) Move KeyValue to hbase-common module
Date Mon, 18 Jun 2012 19:03:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396152#comment-13396152
] 

Matt Corgan commented on HBASE-6162:
------------------------------------

{quote}You don't think it ok just adding new stuff at o.a.hbase? Maybe when we go to HBase
2.0?{quote}
I'm generally in favor of starting to move towards the long term goal as soon as possible,
but thought i'd throw out a warning that it's a pretty ugly transitionary state =)

{quote}(Or are you trying to fix tests in a later module have dependency on code in src/test/java
in an earlier one?){quote}
yep - the hbase-common/src/test/java classes are unfortunately not visible to classes in hbase-server/src/test/java.
 We want things in hbase-common/src/test/java to be visible by downstream tests, for example
LoadTestKVGenerator is pretty fundamental and can be useful for tests in all modules.

Jesse and I are proposing that we put the tests that would go in hbase-common/src/test/java
into hbase-common/src/main/java so they becomes visible downstream.  I like this solution
(at least until maven gets fixed), but now the problem is that "mvn -pl hbase-common test"
doesn't run tests if they're in src/main/java
                
> Move KeyValue to hbase-common module
> ------------------------------------
>
>                 Key: HBASE-6162
>                 URL: https://issues.apache.org/jira/browse/HBASE-6162
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6162-v1.patch, HBASE-6162-v2.patch, HBASE-6162-v3.patch, HBASE-6162-v4.patch,
HBASE-6162-v5.patch
>
>
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is specifically necessary
to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to HConstants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message