hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6012) Handling RegionOpeningState for bulk assign since SSH using
Date Thu, 07 Jun 2012 16:54:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291122#comment-13291122
] 

Zhihong Ted Yu commented on HBASE-6012:
---------------------------------------

{code}
       LOG.info("Unable to communicate with the region server in order" +
           " to assign regions", e);
-      return false;
+      // Server may already get RPC
+      return true;
{code}
What was the reasoning behind the above change ?
{code}
-      try {
-        if (!assign(e.getKey(), e.getValue())) {
-          failedPlans.put(e.getKey(), e.getValue());
-        }
-      } catch (Throwable t) {
+      if (!assign(e.getKey(), e.getValue())) {
{code}
I think the catch clause should be kept.

For HRegionServer.java, there're a lot of formatting changes which distract reviewing.
{code}
+      } catch (RegionAlreadyInTransitionException rie) {
+        LOG.warn("", rie);
{code}
Please add some sentence for the log above.
                
> Handling RegionOpeningState for bulk assign since SSH using
> -----------------------------------------------------------
>
>                 Key: HBASE-6012
>                 URL: https://issues.apache.org/jira/browse/HBASE-6012
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6012.patch, HBASE-6012v2.patch, HBASE-6012v3.patch, HBASE-6012v4.patch,
HBASE-6012v5.patch
>
>
> Since HBASE-5914, we using bulk assign for SSH
> But in the bulk assign case if we get an ALREADY_OPENED case there is no one to clear
the znode created by bulk assign. 
> Another thing, when RS opening a list of regions, if one region is already in transition,
it will throw RegionAlreadyInTransitionException and stop opening other regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message